Skip to content

fix(mothership): preserve workflow identity in background confirmations - #8615

Merged
icecrasher321 merged 1 commit into
stagingfrom
codex/workflow-background-confirmation
Oct 4, 2026
Merged

fix(mothership): preserve workflow identity in background confirmations#8615
icecrasher321 merged 1 commit into
stagingfrom
codex/workflow-background-confirmation

Conversation

@icecrasher321

@icecrasher321 icecrasher321 commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve the bound workflow execution ID when a background confirmation is restored from its durable row. Database reads can win before the transient notification arrives.
  • Strengthen the existing PostgreSQL/Redis settlement regression to verify the durable confirmation as well as the waiting Chat result.

Type of Change

  • Bug fix

Testing

  • 16 PostgreSQL/Redis integration checks against a database provisioned with migrations; the regression failed before the fix and with its response-field guard removed.
  • 89 adjacent tests.
  • Full repository tests (19 workspace tasks; 34,668 app tests), type-check, lint, all 58 audits, standard generators, staging-aware block registry and docs manifest checks.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (test-audit authoring gate applied)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 4, 2026 8:56pm UTC

Request Review

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 4, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds workflow identity to background tool confirmations.

The PR appears safe to merge; no actionable issue was identified.

Summary

Preserves the bound workflow execution ID when a background tool confirmation is reconstructed from its durable row.

  • Adds an integration assertion for the durable confirmation alongside the waiting Chat result.
Diagram 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Workflow execution claim] --> B[Durable tool row]
  B --> C[Background detach preserves claim]
  C --> D[getToolConfirmation restores execution ID]
  D --> E[Workflow waiter returns background result]
Loading

Reviews (1) · Last reviewed commit: "fix(mothership): preserve workflow ident..."

@icecrasher321
icecrasher321 merged commit 80e6602 into staging Oct 4, 2026
33 checks passed
@waleedlatif1 waleedlatif1 mentioned this pull request Oct 5, 2026
Merged
@waleedlatif1
waleedlatif1 deleted the codex/workflow-background-confirmation branch October 5, 2026 07:54

This branch was previously deployed

1 inactive deployment
Preview — 326d936d Deployed Oct 4, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@icecrasher321